ci-operator/step-registry/ipi/deprovision/artifacts/bootstrap: Drop gather #6336
Conversation
openshift-ci-robot
added
the
size/M
|
openshift-ci-robot
added
the
needs-rebase
wking
force-pushed
the
drop-ipi-deprovision-artifacts-bootstrap
branch
from
9df460d
to
c98027b
Compare
openshift-ci-robot
removed
the
needs-rebase
wking
force-pushed
the
drop-ipi-deprovision-artifacts-bootstrap
branch
from
c98027b
to
06448cb
Compare
openshift-ci-robot
added
the
approved
|
Rebased around #6352. CC @AlexNPavel, so you can land this removal and stop have to worry about carrying dead code around ;). |
|
@wking Rehearse not choosing any jobs right now is normal, since there are no jobs using these steps that it can test. In regards to 4.1.z not having the new gather functionality, I'll ask @stevekuznetsov about it, as I'm not quite sure how that will affect us. |
Just means you don't get bootstrap logs from 4.1.z tests that fail before bootstrap removal. If that bothers folks, I think the fix is "backport the auto-gather to the installer's 4.1.z", not "write some CI hack that makes its own Terraform state assumptions". |
|
I'd love to not regress in artifacts in case that will become an issue for people working on backports -- WDYT? |
I bet we end-of-life 4.1 before we hit the next issue that would need these logs for debugging. And if it does come up, I'm happy to volunteer to debug the issue if that allows me to not be on the hook to maintain this Terraform-state-poking crud ;). Also, I've floated the 4.1 backport to get the installer to gather automatically (openshift/installer#2840), although that's not my backport decision to make. |
…ather The installer does this automatically since openshift/installer@cad7f02a8b (cmd: gather the logs from bootstrap instead of printing commands, 2019-06-05, openshift/installer#1822). You'd still need to SSH in to gather manually in 4.1.z, but if we think that's important we should backport the gather logic to the installer's 4.1 branch [1]. [1]: openshift/installer#2840
openshift-ci-robot
added
the
needs-rebase
wking
force-pushed
the
drop-ipi-deprovision-artifacts-bootstrap
branch
from
06448cb
to
970ec02
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…hers Like 970ec02 (ci-operator/step-registry/ipi/deprovision/artifacts/bootstrap: Drop gather, 2019-12-10, openshift#6336), except for the templates instead of the step registry.
The installer does this automatically since openshift/installer@cad7f02a8b (openshift/installer#1822). You'd still need to SSH in to gather manually in 4.1.z, but if we think that's important we should backport the gather logic to the installer's 4.1 branch.